Skip to content

Conversation

0marperez
Copy link
Contributor

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jan 9, 2025

This comment has been minimized.

1 similar comment
Copy link

github-actions bot commented Jan 9, 2025

Affected Artifacts

No artifacts changed size

@0marperez 0marperez marked this pull request as ready for review January 9, 2025 20:39
@0marperez 0marperez requested a review from a team as a code owner January 9, 2025 20:39
Comment on lines +47 to +48
"RpcV2CborClientPopulatesDefaultsValuesWhenMissingInResponse",
"RpcV2CborClientPopulatesDefaultValuesInInput",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing these changes and think we might actually have a bug here, fyi

@0marperez 0marperez merged commit d2e7c91 into main Jan 10, 2025
20 checks passed
@0marperez 0marperez deleted the smithy-version-bump branch January 10, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants